Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 return just number of likes #20

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

macbookfilip
Copy link

No description provided.

@macbookfilip macbookfilip marked this pull request as draft November 25, 2020 21:00
@macbookfilip macbookfilip marked this pull request as ready for review November 25, 2020 21:00
@macbookfilip
Copy link
Author

@macbookfilip macbookfilip reopened this Nov 25, 2020
@macbookfilip
Copy link
Author

macbookfilip commented Nov 25, 2020

@franeklubi There is solution on these issue. Please check them. Thanks

@franeklubi
Copy link
Owner

Yes I will eventually, sorry for the long wait

There's not enough time on my side

@macbookfilip
Copy link
Author

@franeklubi it's OK this pull?

@franeklubi
Copy link
Owner

I don't have time to check, You'll need to wait a little

@macbookfilip
Copy link
Author

Sure i understand. :-) it's OK

@macbookfilip
Copy link
Author

hallo it's OK ? I need know it this week because i will make presentation about my work on this issue in to the school.

@macbookfilip
Copy link
Author

macbookfilip commented Dec 8, 2020

@franeklubi Hi, please can you check my pull request?

@franeklubi
Copy link
Owner

Hi, I've checked Your pull request, and there are a couple of issues.

Firstly, You need to do the same for comments. I didn't write that explicitly, and thought that that was clear, so I'm sorry for omitting that requirement in the original issue.

Now the issue is amended.

Secondly, you don't actually need to fetch the users on the front end, because there's no view to show the users who liked the post, so the fetch is unnecessary.

Sorry for the long wait and sorry for omitting these points in the original issue description.

@macbookfilip
Copy link
Author

@franeklubi in the first task you didn't write something about comments only just post . You can make new task for comments and i can do on it.

@macbookfilip macbookfilip reopened this Dec 9, 2020
@macbookfilip macbookfilip force-pushed the 8_Return_just_number_of_likes branch from ce1ac63 to a71dadb Compare December 9, 2020 22:00
@macbookfilip
Copy link
Author

@franeklubi Hi, Likes on posts and comments are done and fetching the users on the front end was removed. Please let's check this soon as possible because i need know it this week

@macbookfilip
Copy link
Author

@franeklubi Hallo, please can you check my pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants