rtfeldman#446 re-enabled several Unused checks + added exceptions for…

… failing files
frankschmitt · Oct 27, 2020 · fbcb49e · fbcb49e
1 parent 195c27e
commit fbcb49e
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/elm/review/src/ReviewConfig.elm b/elm/review/src/ReviewConfig.elm
@@ -24,13 +24,20 @@ import Review.Rule exposing (Rule)
 
 config : List Rule
 config =
-    [ {- NoUnused.CustomTypeConstructors.rule []
-              , NoUnused.Exports.rule
-              , NoUnused.Modules.rule
-         ,
-      -}
-      --  NoUnused.CustomTypeConstructorArgs.rule -- fails on Test/Runner/Diff.elm
-      NoUnused.Dependencies.rule
+    [ NoUnused.CustomTypeConstructors.rule []
+        |> Review.Rule.ignoreErrorsForFiles
+            [ "src/Test/Reporter/Reporter.elm" --ConsoleReport, JsonReport, JunitReport are used externally
+            , "src/Console/Text.elm" -- Monochrome, UseColor are used externally
+            ]
+
+    --, NoUnused.Exports.rule
+    , NoUnused.Modules.rule
+    , NoUnused.CustomTypeConstructorArgs.rule
+        |> Review.Rule.ignoreErrorsForFiles
+            [ "src/Test/Runner/Node/Vendor/Diff.elm" -- UnexpectedPath is used for reporting errors
+            , "src/Test/Runner/JsMessage.elm" -- Test is used for JSON decoding
+            ]
+    , NoUnused.Dependencies.rule
     , NoUnused.Parameters.rule
     , NoUnused.Patterns.rule
     , NoUnused.Variables.rule