Skip to content

Commit

Permalink
fix: telemetry log when printing
Browse files Browse the repository at this point in the history
  • Loading branch information
18alantom committed Jun 28, 2023
1 parent 18fc0e1 commit 00ce281
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 9 deletions.
9 changes: 5 additions & 4 deletions src/pages/PrintView/PrintView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<PrintContainer
v-if="printProps"
ref="printContainer"
:print-schema-name="schemaName"
:template="printProps.template"
:values="printProps.values"
:scale="scale"
Expand All @@ -55,11 +56,11 @@ import PageHeader from 'src/components/PageHeader.vue';
import { handleErrorWithDialog } from 'src/errorHandling';
import { fyo } from 'src/initFyo';
import { getPrintTemplatePropValues } from 'src/utils/printTemplates';
import { showSidebar } from 'src/utils/refs';
import { PrintValues } from 'src/utils/types';
import { getFormRoute, openSettings, routeTo } from 'src/utils/ui';
import { defineComponent } from 'vue';
import PrintContainer from '../TemplateBuilder/PrintContainer.vue';
import { showSidebar } from 'src/utils/refs';
export default defineComponent({
name: 'PrintView',
Expand Down Expand Up @@ -244,16 +245,16 @@ export default defineComponent({
this.templateList = list.map(({ name }) => name);
},
savePDF() {
async savePDF() {
const printContainer = this.$refs.printContainer as {
savePDF: (name?: string) => void;
savePDF: (name?: string) => Promise<void>;
};
if (!printContainer?.savePDF) {
return;
}
printContainer.savePDF(this.doc?.name);
await printContainer.savePDF(this.doc?.name);
},
async setTemplateFromDefault() {
const defaultName =
Expand Down
13 changes: 8 additions & 5 deletions src/pages/PrintView/ReportPrintView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -145,20 +145,21 @@
</div>
</template>
<script lang="ts">
import { Verb } from 'fyo/telemetry/types';
import { Report } from 'reports/Report';
import { reports } from 'reports/index';
import { OptionField } from 'schemas/types';
import Button from 'src/components/Button.vue';
import Check from 'src/components/Controls/Check.vue';
import Int from 'src/components/Controls/Int.vue';
import Select from 'src/components/Controls/Select.vue';
import PageHeader from 'src/components/PageHeader.vue';
import { getReport } from 'src/utils/misc';
import { PropType, defineComponent } from 'vue';
import ScaledContainer from '../TemplateBuilder/ScaledContainer.vue';
import { getPathAndMakePDF } from 'src/utils/printTemplates';
import { OptionField } from 'schemas/types';
import { paperSizeMap, printSizes } from 'src/utils/ui';
import Select from 'src/components/Controls/Select.vue';
import { showSidebar } from 'src/utils/refs';
import { paperSizeMap, printSizes } from 'src/utils/ui';
import { PropType, defineComponent } from 'vue';
import ScaledContainer from '../TemplateBuilder/ScaledContainer.vue';
export default defineComponent({
components: { PageHeader, Button, Check, Int, ScaledContainer, Select },
Expand Down Expand Up @@ -276,6 +277,8 @@ export default defineComponent({
this.size.width,
this.size.height
);
this.fyo.telemetry.log(Verb.Printed, this.report!.reportName);
},
cellClasses(cIdx: number, rIdx: number): string[] {
const classes: string[] = [];
Expand Down
4 changes: 4 additions & 0 deletions src/pages/TemplateBuilder/PrintContainer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ import {
generateCodeFrame,
SourceLocation,
} from '@vue/compiler-dom';
import { Verb } from 'fyo/telemetry/types';
import ErrorBoundary from 'src/components/ErrorBoundary.vue';
import { getPathAndMakePDF } from 'src/utils/printTemplates';
import { PrintValues } from 'src/utils/types';
Expand All @@ -66,6 +67,7 @@ export default defineComponent({
components: { ScaledContainer, ErrorBoundary },
props: {
template: { type: String, required: true },
printSchemaName: { type: String, required: true },
scale: { type: Number, default: 0.65 },
width: { type: Number, default: 21 },
height: { type: Number, default: 29.7 },
Expand Down Expand Up @@ -179,6 +181,8 @@ export default defineComponent({
this.width,
this.height
);
this.fyo.telemetry.log(Verb.Printed, this.printSchemaName);
},
},
});
Expand Down
1 change: 1 addition & 0 deletions src/pages/TemplateBuilder/TemplateBuilder.vue
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
<div v-if="canDisplayPreview" class="p-4 overflow-auto custom-scroll">
<PrintContainer
ref="printContainer"
:print-schema-name="displayDoc!.schemaName"
:template="doc.template!"
:values="values!"
:scale="scale"
Expand Down

0 comments on commit 00ce281

Please sign in to comment.