Skip to content

Commit

Permalink
chore: use inbuilt notarization
Browse files Browse the repository at this point in the history
- remove notarization script
  • Loading branch information
18alantom committed Feb 16, 2023
1 parent 5b0fab8 commit 708e565
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 34 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,12 @@ jobs:
- name: Run build
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_PASSWORD: ${{ secrets.APPLE_APP_PASSWORD }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
CSC_IDENTITY_AUTO_DISCOVERY: true
GH_TOKEN: ${{ secrets.GH_TOKEN }}
APPLE_NOTARIZE: 1
run: |
yarn set version 1.22.18
yarn electron:build --mac --publish always
Expand Down
21 changes: 0 additions & 21 deletions build/notarize.js

This file was deleted.

4 changes: 2 additions & 2 deletions electron-builder.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
productName: Frappe Books
appId: io.frappe.books
afterSign: build/notarize.js
asarUnpack: '**/*.node'
extraResources:
[
Expand All @@ -11,7 +10,8 @@ mac:
type: distribution
category: public.app-category.finance
icon: build/icon.icns
notarize: false
notarize:
appBundleId: io.frappe.books
hardenedRuntime: true
gatekeeperAssess: false
darkModeSupport: false
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
"electron": "18.3.7",
"electron-builder": "24.0.0-alpha.12",
"electron-devtools-installer": "^3.2.0",
"electron-notarize": "^1.1.1",
"electron-rebuild": "^3.2.9",
"electron-updater": "^5.2.1",
"eslint": "^7.32.0",
Expand Down
8 changes: 0 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5069,14 +5069,6 @@ electron-devtools-installer@^3.2.0:
tslib "^2.1.0"
unzip-crx-3 "^0.2.0"

electron-notarize@^1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/electron-notarize/-/electron-notarize-1.1.1.tgz#3ed274b36158c1beb1dbef14e7faf5927e028629"
integrity sha512-kufsnqh86CTX89AYNG3NCPoboqnku/+32RxeJ2+7A4Rbm4bbOx0Nc7XTy3/gAlBfpj9xPAxHfhZLOHgfi6cJVw==
dependencies:
debug "^4.1.1"
fs-extra "^9.0.1"

[email protected]:
version "24.0.0-alpha.11"
resolved "https://registry.yarnpkg.com/electron-publish/-/electron-publish-24.0.0-alpha.11.tgz#dae4b6880ee457cb4a92f40c975b52d3d49482e8"
Expand Down

0 comments on commit 708e565

Please sign in to comment.