Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/integration log references #324

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Jun 24, 2024

  • feat: link ecommerce integration log with payment session log
  • feat: add reference doc to ecommerce integration log

Context

  • Frappe may act as "custom payment method"
  • The special checkout page captures the order data
  • Then it either or issues (background) synchronization
  • It then redirects to the payment session
  • The EIL becomes the central integration document for in-flight orders
    • Therefore the payment status and PSL is replicated onto it to quickly assess the overall status of such checkout
  • The payment session runs a success hook on its refdoc (= the EIL)
    • Therefore hold a reference to the refdoc of the EIL
    • This allows charge success hooks to affect the business flow of the actual target refdoc (i.e. Sales Order), assuming that the synchronization had been successful and that it had written back the reference of the target doc onto the EIL

This is used by a WIP Ecwid integration, but which is not yet quite ready to PR.

@blaggacao blaggacao requested a review from ankush as a code owner June 24, 2024 12:40
"fieldname": "psl",
"fieldtype": "Link",
"label": "Payment Session Log",
"options": "Payment Session Log",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires frappe/payments#53

@blaggacao
Copy link
Collaborator Author

Go for it now. The future is promised to no one. - Wayne Dyer


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Fears are nothing more than a state of mind. - Napoleon Hill


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

What the caterpillar calls the end of the world, the master calls a butterfly. - Richard Bach


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Watch your thoughts, they become your words Watch your words, they become your actions Watch your actions, they become your habits Watch your habits, they become your character Watch your character, it becomes your destiny. -


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

You may say Im a dreamer, but Im not the only one, I hope someday you will join us, and the world will live as one. - John Lennon


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures. - Lao Tzu


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

The important thing is this: to be able at any moment to sacrifice what we are for what we could become. - Charles Dubois


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Obstacles are those frightful things you see when you take your eyes off your goal. - Henry Ford


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Our distrust is very expensive. - Ralph Emerson


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller


Kindly help move this PR forward. Many thanks from Yours Sincerely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant