fix: updated label "Is short year" to "Is Short/Long year" for both short and long fiscal years #44145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajiragroup
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
ajiragroup
changed the title
ruthra-kumar
approved these changes
Nov 19, 2024
ruthra-kumar
force-pushed
the
ajiragroup-patch-1
branch
from
a7f288d
to
5b8a672
Compare
Is short/long year.
ruthra-kumar
force-pushed
the
ajiragroup-patch-1
branch
from
5b8a672
to
1d6b9b4
Compare
ruthra-kumar
added a commit
that referenced
this pull request
Nov 19, 2024
…-44145 fix: updated label "Is short year" to "Is Short/Long year" for both short and long fiscal years (backport #44145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is short/long year.
FY can be short or long here in Nepal.
FY starts in July every year, but date can be 15/16/17 which varies every year.
Also FY end date can be different.
For ex. any of this is possible:
Same goes for other dates.
The
Is short yearcheck mark seems to work good for long years as well. So, decided to update the text label to avoid confusion.