Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: payment reco for jv with negative dr or cr amount #44197

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: payment reco for jv with negative dr or cr amount #44197

merged 2 commits into from
Nov 20, 2024
+149 −7

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Nov 18, 2024 •
edited
Loading

Currently, Payment Reconciliation for Journal Entries with negative debit or credit amounts is not supported.
Steps To Replicate:

  • Create a Purchase Invoice.
  • Create a Journal Entry with a negative credit balance for payment.
  • Use the Payment Reconciliation tool for reconciling.(Entry will not be fetched.)

image

backport version-15

@ljain112 ljain112 marked this pull request as draft November 18, 2024 14:38
@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 18, 2024
@ljain112 ljain112 marked this pull request as ready for review November 18, 2024 15:12
@ruthra-kumar ruthra-kumar self-assigned this Nov 19, 2024
@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 November 19, 2024 08:45
@ruthra-kumar ruthra-kumar added backport version-15-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Nov 20, 2024
@ruthra-kumar ruthra-kumar merged commit 1737269 into frappe:develop Nov 20, 2024
15 checks passed
This was referenced Nov 20, 2024
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Nov 20, 2024
@ruthra-kumar
Merge pull request #44245 from frappe/mergify/bp/version-15-hotfix/pr…
4afd4b4 
…-44197

fix: payment reco for jv with negative dr or cr amount (backport #44197)
ruthra-kumar added a commit that referenced this pull request Nov 20, 2024
@ruthra-kumar
Merge pull request #44244 from frappe/mergify/bp/version-14-hotfix/pr…
24126b0 
…-44197

fix: payment reco for jv with negative dr or cr amount (backport #44197)
@jnoufaily

This comment was marked as outdated.

Sign in to view
@ruthra-kumar

This comment was marked as outdated.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar ruthra-kumar approved these changes

Assignees

@ruthra-kumar ruthra-kumar

Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljain112 @jnoufaily @ruthra-kumar