Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove validate_name_in_customer function (backport #41025) #44221

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Problem:
When we create a customer group the function "validate_name_with_customer" is called which checks whether the name of customer group exists in "Customer" DocType.
For e.g.
If we create a customer group called "XYZ", in the on_update method in customer_group.py file, the code will check whether a customer with a name of "XYZ" is already created or not. If it is created it throws an error "A customer with the same name already exists".

Solution:
Remove validate_name_with_customer from "customer_group.py" file.


This is an automatic backport of pull request #41025 done by Mergify.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 19, 2024
@ruthra-kumar ruthra-kumar merged commit bc03b68 into version-15-hotfix Nov 20, 2024
12 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-41025 branch November 20, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants