Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hd team and hd agent #2037

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Nov 7, 2024

Issue
Currently we have duplicated data.

  1. HD Team: This DocType has a table of Users.
  2. HD Agent: This DocType has a table of HD Team.

Solution:
The correct way is to have control on Team level, that is remove the table from HD Agent, and only support from HD Team.

What Changed?

  1. Wrote a patch for the same
  2. Removes Groups Table from HD Agent DocType and removed related functions.
  3. Updating HD Team will update users in the Assignment Rule. (On changing HD Team Users => Update the assignment rule (previously done by HD Agent))
  4. Refactor HD Ticket => Write functions which uses HD Team users instead of HD Agent Groups.

@RitvikSardana RitvikSardana changed the title refactor: hd team and assignment rules flow refactor: hd team and hd agent Nov 13, 2024
@RitvikSardana RitvikSardana marked this pull request as ready for review November 13, 2024 08:38
@RitvikSardana RitvikSardana merged commit 35a9f01 into frappe:develop Nov 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant