Merge pull request #21 from bosue/no_zero_disbursement

fix: Disallow zero disbursement
frappe · Sep 16, 2023 · 1566693 · 1566693 · bosue · Sep 16, 2023
2 parents c7df023 + 6f53aa0
commit 1566693
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lending/loan_management/doctype/loan_disbursement/loan_disbursement.py b/lending/loan_management/doctype/loan_disbursement/loan_disbursement.py
@@ -87,7 +87,10 @@ def delete_security_deposit(self):
 	def validate_disbursal_amount(self):
 		possible_disbursal_amount = get_disbursal_amount(self.against_loan)
 
-		if self.disbursed_amount > possible_disbursal_amount:
+		if not self.disbursed_amount:
+			frappe.throw(_("Disbursed amount cannot be zero"))
+
+		elif self.disbursed_amount > possible_disbursal_amount:
 			frappe.throw(_("Disbursed Amount cannot be greater than {0}").format(possible_disbursal_amount))
 
 	def set_status_and_amounts(self, cancel=0):