Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: one security to many loans #108

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

feat: one security to many loans #108

wants to merge 14 commits into from

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 19, 2023 •
edited
Loading

image

@frappe frappe deleted a comment from mergify bot Oct 20, 2023
@mergify
Copy link

mergify bot commented Oct 20, 2023

copy poc-stagin

❌ No copy have been created

  • Copy to branch poc-stagin failed

GitHub error: Branch not found

@deepeshgarg007
Copy link
Member Author

@Mergifyio copy poc-staging

@mergify
Copy link

mergify bot commented Oct 20, 2023 •
edited
Loading

copy poc-staging

✅ Pull request copies have been created

@mergify mergify bot mentioned this pull request Oct 20, 2023
Merged
deepeshgarg007 added a commit that referenced this pull request Oct 20, 2023
@deepeshgarg007
Merge pull request #109 from frappe/mergify/copy/poc-staging/pr-108
1f4884e 
feat: Assign multiple securities to one loan (#108)
@anandbaburajan anandbaburajan mentioned this pull request Oct 20, 2023
Closed
@bosue
Copy link
Contributor

bosue commented Oct 24, 2023 •
edited
Loading

You mean the other way around: “Assign security/ies to multiple loans”?
Assigning multiple securities to one loan should already work.

Sry, I’m not nitpicking for its own sake, just trying to understand… 😅

@anandbaburajan anandbaburajan changed the title feat: Assign multiple securities to one loan feat: one security to many loans Oct 25, 2023
@anandbaburajan anandbaburajan marked this pull request as draft October 25, 2023 02:28
@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review November 30, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbaburajan anandbaburajan Awaiting requested review from anandbaburajan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepeshgarg007 @bosue @anandbaburajan