Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc UI fixes #1033

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: misc UI fixes #1033

merged 2 commits into from
Sep 27, 2024

Conversation

pateljannat
Copy link
Collaborator

  1. Initialise telemetry only if the user is logged in.
  2. Fixed the telemetry capture during lesson progress.
  3. Fixed the UI of Live Class listing

Copy link

cypress bot commented Sep 27, 2024

lms    Run #699

Run Properties:  status check passed Passed #699  •  git commit 7bb0ef9728 ℹ️: Merge 7c055af496717d9b5f70373ac8d272a40b5636bd into bb9b179e05b81ddfff75fdf73048...
Project lms
Branch Review issues-35
Run status status check passed Passed #699
Run duration 00m 31s
Commit git commit 7bb0ef9728 ℹ️: Merge 7c055af496717d9b5f70373ac8d272a40b5636bd into bb9b179e05b81ddfff75fdf73048...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit d295898 into frappe:develop Sep 27, 2024
5 checks passed
@pateljannat pateljannat deleted the issues-35 branch September 27, 2024 16:45
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants