Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add required attribute and make tab sticky in batches #1102

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

iamejaaz
Copy link
Contributor

@iamejaaz iamejaaz commented Nov 7, 2024

Maybe closes #899

Changes in PR

  • Add required attribute in batches form
  • Make Tabs sticky in Batches

Screenshot or video

Screen.Recording.2024-11-07.at.10.59.07.AM.mov

Copy link

cypress bot commented Nov 7, 2024

lms    Run #798

Run Properties:  status check passed Passed #798  •  git commit ea9942e407 ℹ️: Merge 0dcfd7e482c312a69c1c41f8931bada606d66f0d into c5f091fae8a6bb588fcf06b66e8f...
Project lms
Branch Review make-tab-sticky
Run status status check passed Passed #798
Run duration 00m 30s
Commit git commit ea9942e407 ℹ️: Merge 0dcfd7e482c312a69c1c41f8931bada606d66f0d into c5f091fae8a6bb588fcf06b66e8f...
Committer Ejaaz Khan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit a643e9a into frappe:develop Nov 12, 2024
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs "disappear" when we switch to Discussions tab in manage batch page
3 participants