Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keyboard shortcut to save lesson #1135

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

iamejaaz
Copy link
Contributor

Closes #1121

Changes in PR:

  • Users can now save a lesson using a shortcut.
  • A toast message will appear when a lesson is saved manually.
  • The toast message will be hidden when the lesson is auto-saved.

Copy link

cypress bot commented Nov 16, 2024

lms    Run #822

Run Properties:  status check passed Passed #822  •  git commit de30f01e69 ℹ️: Merge a4fa2ef0b31dc34a9ca660968401e6a3e7500b70 into dfb22c81c3c3cd9d4d9f569847dd...
Project lms
Branch Review add-keyboard-shortcut
Run status status check passed Passed #822
Run duration 00m 29s
Commit git commit de30f01e69 ℹ️: Merge a4fa2ef0b31dc34a9ca660968401e6a3e7500b70 into dfb22c81c3c3cd9d4d9f569847dd...
Committer Ejaaz Khan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 0097ede into frappe:develop Nov 19, 2024
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for CTRL + S
3 participants