Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slides rendering issue #997

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

pateljannat
Copy link
Collaborator

  1. Google Slides was not getting rendered in lessons.
  2. Fixed the regex to resolve the issue.

Copy link

cypress bot commented Aug 29, 2024

lms    Run #656

Run Properties:  status check passed Passed #656  •  git commit a5d22fb983 ℹ️: Merge 65d628ffc00cbfcda3d9872b7ae784bfadb70290 into bf290bbf0ac3152850ad44f5e6b7...
Project lms
Branch Review issues-33
Run status status check passed Passed #656
Run duration 00m 39s
Commit git commit a5d22fb983 ℹ️: Merge 65d628ffc00cbfcda3d9872b7ae784bfadb70290 into bf290bbf0ac3152850ad44f5e6b7...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit e07aae3 into frappe:develop Aug 29, 2024
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants