fix: header_img field schema (backport #83) #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NagariaHussain could you please review this backport for Frappe Payments? I think it's important to fix GoCardless in production setups, which has been broken for a long time. I also backported it to version 14 here. Thank you! |
|
Sorry, copy/paste error in URL for the PR over on the frappe/erpnext version-14 backport (this json file is still part of erpnext on version-14). frappe/erpnext#42438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #83 to version-15, updating the schema of gocardless_settings.json to include the header_img field so GoCardless can be functional. Thank you!