Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RemoteFile): Don't try to delete unavailable S3 file #2259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Nov 5, 2024

If I'm not mistaken, unavailable Remote Files could be removed (like other Log Types) once they become unavailable.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.94%. Comparing base (2f435f8) to head (b6b667a).

Files with missing lines Patch % Lines
press/press/doctype/remote_file/remote_file.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2259      +/-   ##
==========================================
- Coverage   29.94%   29.94%   -0.01%     
==========================================
  Files         371      371              
  Lines       28078    28079       +1     
==========================================
  Hits         8408     8408              
- Misses      19670    19671       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant