-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movement PID #20
base: master
Are you sure you want to change the base?
Movement PID #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this branch needs a merge from master, but overall it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just s few more changes...
Things to do still:
- make changes
- test one final time on 2018 robot
- revert all changes made for testing on 2018 (drivebase, robotmap, autonomous command)
- merge master into this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to roll back test code.
@@ -86,7 +88,8 @@ public void disabledPeriodic() { | |||
*/ | |||
@Override | |||
public void autonomousInit() { | |||
m_autonomousCommand = m_chooser.getSelected(); | |||
m_autonomousCommand = new DriveForDistance(240, 100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this back to the original so that we do not have an auto command in use
public static final int LEFT_BACK = 6; | ||
public static final int LEFT_FRONT = 1; | ||
public static final int LEFT_MIDDLE = 2; | ||
public static final int LEFT_BACK = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change these back to the original values before we merge
/** | ||
*DriveBase is the representation of the physical drive motors and provides access to their motor controllers. | ||
*/ | ||
public class DriveBase extends Subsystem { | ||
private VictorSPX leftFront; | ||
private VictorSPX leftMiddle; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert back the motor setup that we have for 2019 robot.
This includes a turning with Gyro Pid and a movement with encoder with Pid.