Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movement PID #20

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Movement PID #20

wants to merge 10 commits into from

Conversation

JaysonHahn
Copy link

This includes a turning with Gyro Pid and a movement with encoder with Pid.

Copy link
Contributor

@jdlanning jdlanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this branch needs a merge from master, but overall it looks good!

src/main/java/frc/robot/RobotMap.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/MoveForDistance.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/MoveForDistance.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/MoveForDistance.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/MoveForDistance.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/TurnForAngle.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/TurnForAngle.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/TurnForAngle.java Outdated Show resolved Hide resolved
Copy link
Contributor

@jdlanning jdlanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just s few more changes...

Things to do still:

  • make changes
  • test one final time on 2018 robot
  • revert all changes made for testing on 2018 (drivebase, robotmap, autonomous command)
  • merge master into this branch

src/main/java/frc/robot/commands/DriveForDistance.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/TurnForAngle.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/TurnForAngle.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/TurnForAngle.java Outdated Show resolved Hide resolved
Copy link
Contributor

@jdlanning jdlanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to roll back test code.

@@ -86,7 +88,8 @@ public void disabledPeriodic() {
*/
@Override
public void autonomousInit() {
m_autonomousCommand = m_chooser.getSelected();
m_autonomousCommand = new DriveForDistance(240, 100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this back to the original so that we do not have an auto command in use

public static final int LEFT_BACK = 6;
public static final int LEFT_FRONT = 1;
public static final int LEFT_MIDDLE = 2;
public static final int LEFT_BACK = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change these back to the original values before we merge

/**
*DriveBase is the representation of the physical drive motors and provides access to their motor controllers.
*/
public class DriveBase extends Subsystem {
private VictorSPX leftFront;
private VictorSPX leftMiddle;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert back the motor setup that we have for 2019 robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants