Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArmSubsystem Unit Testing #49

Closed
wants to merge 32 commits into from
Closed

ArmSubsystem Unit Testing #49

wants to merge 32 commits into from

Conversation

jagernet-ops
Copy link
Contributor

@jagernet-ops jagernet-ops commented Feb 17, 2024 •
edited
Loading

#39

Mr-Smiggles and others added 24 commits January 26, 2024 00:55
@Mr-Smiggles
Created multiple variables and methods for arm subsystem.
59b3d7d
@Mr-Smiggles
Updated ranges for boolean methods.
b5c65b6
@Mr-Smiggles
Put in constants for homeSwitch and Encoder channels
976f30b
@Mr-Smiggles
Created commands for arm subsystem
cd2182c
@Mr-Smiggles
Added home switch failsafe
37149f6
@Mr-Smiggles
Merge branch 'main' into armsubsystem
37ffe1e
@Mr-Smiggles
Changed requests
b065deb
@python-42
Worked through arm periodic movement w/ Jason and Noah
03be830
@Mr-Smiggles
Changed requests for arm subsystem.
b119f04
@Mr-Smiggles
Added simulation support and controller buttons
8861020
@Mr-Smiggles
Added debouncer and changed requests
e2ee51a
@Mr-Smiggles
Made request changes, added Shuffleboard and info for it, and added l…
a79f035 
…ow scoring position in constants.
@NoahWeishan
Created interface for the arm subsystem
2ec5a97
@NoahWeishan
changed digital input into a variable in the SimArmIO
3dbb3cf
@NoahWeishan
Changed constants names to imporve readability and remove redundency
435cf5c
@NoahWeishan
Fixed PID loop and improved methods in subsystem
8a05673
@NoahWeishan
added PID widget to the shuffleboard
691649a
@NoahWeishan
Changed PID to a Profiled PID
38b3e78
@NoahWeishan
Changed how PID calculates motor power
daaf772
@NoahWeishan
Added arm graphic for display
7458679
@jagernet-ops
merged with main
e624f19
@jagernet-ops
added unit tests for arm logic
ce508b7
@NoahWeishan
Inverted motor one
4b3c96b
@jagernet-ops
merged with arm-interface-refactor
0be7ed3
@jagernet-ops jagernet-ops added the code quality Anything that helps our code be cleaner. Think logging, CICD, unit testing, etc label Feb 17, 2024
@jagernet-ops jagernet-ops self-assigned this Feb 17, 2024
@jagernet-ops jagernet-ops changed the title ArmSubsystem Unit Testing #39 ArmSubsystem Unit Testing [#39](https://github.com/orgs/frc1675/projects/3/views/1?pane=issue&itemId=53048516) Feb 17, 2024
@jagernet-ops jagernet-ops changed the title ArmSubsystem Unit Testing [#39](https://github.com/orgs/frc1675/projects/3/views/1?pane=issue&itemId=53048516) ArmSubsystem Unit Testing (#39)[https://github.com/orgs/frc1675/projects/3/views/1?pane=issue&itemId=53048516] Feb 17, 2024
@jagernet-ops jagernet-ops changed the title ArmSubsystem Unit Testing (#39)[https://github.com/orgs/frc1675/projects/3/views/1?pane=issue&itemId=53048516] ArmSubsystem Unit Testing Feb 17, 2024
@pordonj
Copy link
Contributor

pordonj commented Mar 6, 2024 •
edited
Loading

Please merge main into your branch (everything that isnt your test stuff should use main's implementation) and go from there

@pordonj
Copy link
Contributor

pordonj commented Apr 20, 2024

so much has changed closing this

@pordonj pordonj closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pordonj pordonj Awaiting requested review from pordonj

@python-42 python-42 Awaiting requested review from python-42

Assignees

@jagernet-ops jagernet-ops

Labels
code quality Anything that helps our code be cleaner. Think logging, CICD, unit testing, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jagernet-ops @pordonj @Mr-Smiggles @python-42 @NoahWeishan