Current Dashboard #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pordonj
requested changes
Mar 23, 2024
| try (PowerDistribution PDH = new PowerDistribution(1, ModuleType.kRev)) { | ||
| tab.addDouble("Right Arm Motor Current",()-> PDH.getCurrent(18)); | ||
| tab.addDouble("Left Arm Motor Current",()-> PDH.getCurrent(5)); | ||
| } catch(Exception e){ |
There was a problem hiding this comment.
what can throw an exception here?
pordonj
requested changes
Apr 18, 2024
| tab.addDouble("Right Arm Motor Current",() -> PDH.getCurrent(18)); | ||
| tab.addDouble("Left Arm Motor Current",() -> PDH.getCurrent(5)); | ||
| //Shooter Motors | ||
| tab.addDouble("Shooter Motor 1 Current",() -> PDH.getCurrent(6)); |
There was a problem hiding this comment.
Lets make a TEMPORARY (like, we are going toi delete it before merging this) command for the shooter subsystem that takes in a can id and runs the motor for that can id at like 10%. Then we can watch this dashboard and know whiuch PD channel corresponds to each can ID. Then record that in Constants and delete the temp command.
| if (currentNeedsInit){ | ||
| ShuffleboardTab tab = Shuffleboard.getTab("Current Info"); | ||
| //Arm Motors | ||
| tab.addDouble("Right Arm Motor Current",() -> PDH.getCurrent(18)); |
There was a problem hiding this comment.
All these PDH channels used in the getCurrent calls should be defined in Constants (maybe make a PDH class in constants to store them)
pordonj
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get current values from the PDH and display them on a dashboard.