Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom call changes (now reading joystick values correctly) #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

AaronMcGarry
Copy link
Contributor

No description provided.

Copy link
Contributor

@jdlanning jdlanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments ... nice work ... your PR title is fitting for 2020 🙂

Gobabygo/Gobabygo.ino Outdated Show resolved Hide resolved
Gobabygo/Gobabygo.ino Outdated Show resolved Hide resolved
Gobabygo/Gobabygo.ino Outdated Show resolved Hide resolved
Gobabygo/Gobabygo.ino Outdated Show resolved Hide resolved
@jdlanning
Copy link
Contributor

Looks good, let’s keep this open until we confirm all is working on the car itself.

This will be our starting point for testing today

Copy link
Contributor

@jdlanning jdlanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, see the comments below

Gobabygo/Gobabygo.ino Outdated Show resolved Hide resolved
Gobabygo/Gobabygo.ino Outdated Show resolved Hide resolved
Gobabygo/Gobabygo.ino Outdated Show resolved Hide resolved
Gobabygo/Gobabygo.ino Show resolved Hide resolved
Copy link
Contributor

@jdlanning jdlanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent changes look good. Just one comment still remains from the last review.

Gobabygo/Gobabygo.ino Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants