Crash: (UI Menu) Windows -> Recreate Plugin Window (with no plugin loaded) #42
Comments
NatureIsFrequency
added a commit
to NatureIsFrequency/clap-host
that referenced
this issue
Feb 7, 2024
Guard against null _plugin within PluginHost::setParentWindow Follow error convention in source code Tested arch: arm64 Confirm no longer crash
Closed
NatureIsFrequency
added a commit
to NatureIsFrequency/clap-host
that referenced
this issue
Feb 9, 2024
Per @Trinitou suggestions, a plugin specific menu item should only be enabled (available to execute by user) This fixes the underlying cause of the crashes reported in free-audio#40 and free-audio#42 Therefore this also reverts the now obsolete change in previous merged pull request free-audio#43 Upon load change we update the menu items Tab indentation set to 3 to be consistent with existing code Note: Follows the QT memory ownership model, and the QAction pointers lifetime is handled by their parents Testing: Launch with no plugin loaded, see menu items are greyed out (disabled), user cannot select these items (as intended) therefore code is not executed and app doesn't crash Launch with plugin loaded, see menu items are available and executed when user clicks, and confirm still no crashes Images taken for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro steps:
Reason for the crash:
PluginHost::setParentWindow doesn't guard against _plugin being nullptr
Proposed fix:
Have a local patch for this which I'll pull request and reference this issue
Further details:
Image for how to reproduce:
Crash report:
clap-host-2024-02-06-230842.txt
The text was updated successfully, but these errors were encountered: