Enable/Disable Menu items based on plugin loaded #45
Conversation
Per @Trinitou suggestions, a plugin specific menu item should only be enabled (available to execute by user) This fixes the underlying cause of the crashes reported in free-audio#40 and free-audio#42 Therefore this also reverts the now obsolete change in previous merged pull request free-audio#43 Upon load change we update the menu items Tab indentation set to 3 to be consistent with existing code Note: Follows the QT memory ownership model, and the QAction pointers lifetime is handled by their parents Testing: Launch with no plugin loaded, see menu items are greyed out (disabled), user cannot select these items (as intended) therefore code is not executed and app doesn't crash Launch with plugin loaded, see menu items are available and executed when user clicks, and confirm still no crashes Images taken for testing
Per @Trinitou feedback: 1. pluginLoadedChanged is now a signal of PluginHost 2. Connect MainWindow:: updatePluginMenuItems to this signal 3. Rename updateMenuItems to updatePluginMenuItems (so it specifies it's these are plugin related menu items) 4. Remove i_prefix in function parameter to follow code style 5. Use default argument false for updatePluginMenuItems
There was a problem hiding this comment.
after the adjustments, the changes feel a lot more "native" now 👍
not completely sure whether the assert is really necessary.
Another idea that came into my mind: updatePluginMenuItems even could be a local lambda which captures the menu actions so those even don't have to be members.
All in all, I'd say it's done and maybe let's hear what @abique thinks about it before doing any further adjustments. IMO we could already take it like it is.
|
I haven't tested it, but if you both tested it and it works well for you, then I trust both of you 👍 |
|
Cheers @abique, tested my end on Mac Arm64 (no windows to hand a the mo). Big thanks for the merge, and if I get some time later in the week I'll take a look at the plugin load menu item too, have a good week 👍 |
Per @Trinitou suggestions, a plugin specific menu item should only be enabled (available to execute by user) when the plugin is loaded, and disabled when the plugin is not loaded
Fixes
This fixes the underlying cause of the crashes reported in #40 and #42
Fix for #40
Fix for #42
Details
Upon plugin load change we update the menu items
Reverts the now obsolete change in previous merged pull request #43
Tab indentation set to 3 to be consistent with existing code
Note: Follows the QT memory ownership model, and the QAction pointers lifetime is handled by their parents
Testing
Arm64 Debug
user cannot select these items (as intended) therefore code is not executed and app doesn't crash
confirm still no crashes
Test 1: Plugin not loaded
Test 2: Plugin loaded