fix: ULCL not working; close #141 #147
Conversation
|
@lyz508 Thanks! |
internal/context/sm_context.go
Outdated
| @@ -587,7 +605,7 @@ func (c *SMContext) SelectDefaultDataPath() error { | |||
| c.Log.Infof("Has pre-config default path") | |||
| uePreConfigPaths := GetUEPreConfigPaths(c.Supi, c.SelectedUPF.Name) | |||
| for _, dp := range uePreConfigPaths.DataPathPool { | |||
| if !dp.IsDefaultPath { | |||
| if dp.IsDefaultPath { | |||
There was a problem hiding this comment.
Hi, @louisroyer,
If we add the default path created by the ULCL config here,
SMF will create a PDR without a decision from the PCF (e.g., additional charging URRs).
Maybe we could directly use the default path created by PCC rules?
There was a problem hiding this comment.
Hi @lyz508,
how can we use this path? According to
smf/internal/sbi/processor/pdu_session.go
Line 228 in 9ab42f1
SelectDefaultDataPath is called to create the default datapath when it is not found…
There was a problem hiding this comment.
Hi, @louisroyer,
Sorry for the late reply.
Maybe we could add a check before adding the ULCL default path to SMContext?
defaultPath = uePreConfigPaths.DataPathPool.GetDefaultPath()
if c.Tunnel.DataPathPool.GetDefaultPath() == nil {
c.Tunnel.AddDataPath(defaultPath)
}
Since the default path is added to SMContext when handling PCCRules creation, this approach would help prevent duplicate creation of the default path.
smf/internal/context/sm_context.go
Line 649 in 9ab42f1
There was a problem hiding this comment.
@louisroyer Yes, thanks for the update!
|
@ianchen0119 LGTM. |
|
Hi @Alonza0314 Please test the PR on next branch by using CI-TEST. Thanks. |
|
I rebased on next. |
It passed the tests. 🎉 |
No description provided.