fix: the tests checks if they can set the environment variables

free5gc · Feb 28, 2025 · 7622c81 · 7622c81
1 parent 738b5fe
commit 7622c81
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/internal/context/context_test.go b/internal/context/context_test.go
@@ -253,8 +253,12 @@ func TestInitUdmContextWithConfigIPv6FromEnv(t *testing.T) {
 
 	configFile := createConfigFile(t, postContent)
 
-	os.Setenv("MY_REGISTER_IP", "2001:db8::1:0:0:130")
-	os.Setenv("MY_BINDING_IP", "2001:db8::1:0:0:130")
+	if err := os.Setenv("MY_REGISTER_IP", "2001:db8::1:0:0:130"); err != nil {
+		t.Errorf("Can't set MY_BINDING_IP variable environnement: %+v", err)
+	}
+	if err := os.Setenv("MY_BINDING_IP", "2001:db8::1:0:0:130"); err != nil {
+		t.Errorf("Can't set MY_BINDING_IP variable environnement: %+v", err)
+	}
 
 	// Test the initialization with the config file
 	cfg, err := factory.ReadConfig(configFile.Name())

diff --git a/pkg/factory/config.go b/pkg/factory/config.go
@@ -77,9 +77,7 @@ type Logger struct {
 
 func (c *Configuration) validate() (bool, error) {
 	if sbi := c.Sbi; sbi != nil {
-		if result, err := sbi.validate(); err != nil {
-			return result, err
-		}
+		sbi.validate()
 	} else {
 		sbi := Sbi{}
 		result, err := sbi.validate()