-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/OAuth2 #33
feature/OAuth2 #33
Conversation
a3828162
commented
Jan 23, 2024
- Use Middleware for authorization
- Consumer retrieve token
- Replace the service name in each HTTP request of the producer with the OpenAPI name
- Complete unit test of router_auth_check_test.go
2. modify nudr.dm to nudr.dr 3. remove NewRouterAuthorizationChekck in AddService() in every producer router.go 4. add _ NFContext = &UDMContext in context.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @a3828162
Please update the patch based on my comments.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
internal/util/util.go
Outdated
) | ||
|
||
const ( | ||
NfTypeNRF = models.NfType_NRF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to define const again, directly use models
internal/util/util.go
Outdated
@@ -13,6 +13,23 @@ const ( | |||
UdmDefaultConfigPath = "./config/udmcfg.yaml" | |||
) | |||
|
|||
const ( | |||
ServiceNameNnrfDisc = string(models.ServiceName_NNRF_DISC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to define const again, directly use string(models.ServiceNAme_xxx)