Updated dependencies #2334
Open
Updated dependencies #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon04
requested changes
Nov 17, 2024
There was a problem hiding this comment.
Hi, simply updating the versions/releases is easy. Running the scrapers, adapting to documentation changes, fixing the scrapers, verifying that everything is fine is where the effort lies.
You stated " Tested the changes locally to ensure: The scraper still works without errors" – however the angular scraper immediately fails:
> bundle exec thor docs:generate --force --package angular
bundler: failed to load command: thor (/Users/simon/src/devdocs/vendor/bundle/ruby/3.3.0/bin/thor)
/Users/simon/src/devdocs/vendor/bundle/ruby/3.3.0/gems/yajl-ruby-1.4.3/lib/yajl/json_gem/parsing.rb:15:in `rescue in parse': lexical error: invalid char in json text. (JSON::ParserError)
<!DOCTYPE html><!-- We set all
(right here) ------^
from /Users/simon/src/devdocs/vendor/bundle/ruby/3.3.0/gems/yajl-ruby-1.4.3/lib/yajl/json_gem/parsing.rb:11:in `parse'
from /Users/simon/src/devdocs/lib/docs/scrapers/angular.rb:39:in `block in initial_urls'
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're updating existing documentation to its latest version, please ensure that you have:
SOURCEfile inpublic/icons/your_scraper_name/are up-to-date if the documentation has a custom iconself.linkscontains up-to-date urls ifself.linksis defined