Make PyMuPDF always log to stderr #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
approved these changes
Aug 8, 2024
PyMUPDF logs to stdout by default, which is problematic because we use the stdout of the conversion process to read the pixel stream of a document. Make PyMuPDF always log to stderr, by setting the following environment variables: PYMUPDF_MESSAGE and PYMUPDF_LOG. Fixes #877
Some of the files in our large test set can make LibreOffice hang. We do not have a proper solution for this yet, but we can at least make the tests timeout quickly, so that they can finish at some point. Refs #878
apyrgio
force-pushed
the
877-reduce-errors
branch
from
d41b840 to
cfb5e75
Compare
|
Yeap, it's too hacky for my liking, and I've opened an issue for that. Anw, we have to live with it... Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMUPDF logs to stdout by default, which is problematic because we use the stdout of the conversion process to read the pixel stream of a document.
Make PyMuPDF always log to stderr, by setting the following environment variables:
PYMUPDF_MESSAGEandPYMUPDF_LOG.Also, set a 5 minute timeout for document processing, when we run our large tests.
Fixes #877
Refs #878