Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7415 - Reformatted webdriver creation for test setup to use only one function for the creation of the webdriver #7439

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alberefe
Copy link

Description

Reformatted the creation of webdrivers for functional test setup

Status

Ready for review

Description of Changes

Fixes #7415

Changes proposed in this pull request:

Unified the creation of webdriver in one function that takes the type of webdriver as parameter
The creation is the same, it's just only in one function instead of two
Simplified get_web_driver

Testing

How should the reviewer test this PR?
Write out any special testing steps here.

I have read that github runs tests automatically, so these should check that the changes are good to go.

Deployment

Any special considerations for deployment? Consider both:

Nothing should have changed.

Checklist

  • These changes do not require documentation

Choose one of the following:

  • I would like someone else to do the diff review (first ever pull request, I think everything is okay but would like to have it checked)

@alberefe alberefe requested a review from a team as a code owner February 11, 2025 17:22
@cfm cfm self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

securedrop.tests.functional.web_drivers: refactor to parameterize on driver class
2 participants