Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ReferenceCitation): use resolved_case_name and resolved_case_name_short for search and resolution #200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Feb 1, 2025

Fixes #199

  • updated ReferenceCitation and FullCaseCitation models metadata to admit resolved_case_name_short and resolved_case_name
  • update helpers.filter_citations to save metadata of duplicated ReferenceCitations on the kept object
  • update tests to show how the finding and resolution will work

@grossir grossir force-pushed the 199-resolved-case-names-for-reference-citations branch from 9805ef2 to 326e45a Compare February 1, 2025 00:35
…e_short for search and resolution

Fixes #199

- updated ReferenceCitation and FullCaseCitation models metadata to admit resolved_case_name_short and resolved_case_name
- update helpers.filter_citations to save metadata of duplicated ReferenceCitations on the kept object
- update tests to show how the finding and resolution will work
@grossir grossir force-pushed the 199-resolved-case-names-for-reference-citations branch from 326e45a to e0e79f1 Compare February 1, 2025 00:37
@grossir grossir assigned grossir and flooie and unassigned grossir Feb 1, 2025
@flooie
Copy link
Contributor

flooie commented Feb 1, 2025

thanks @grossir looking forward to reviewing this

Copy link
Contributor

github-actions bot commented Feb 3, 2025

The Eyecite Report 👁️

Gains and Losses

There were 0 gains and 0 losses.

Click here to see details.
id Gain Loss

Time Chart

image

Generated Files

Branch 1 Output
Branch 2 Output
Full Output CSV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PRs to Review
Development

Successfully merging this pull request may close these issues.

Use resolved object's metadata to find ReferenceCitations
2 participants