WIP: Misbehavior of HTML Parsing

[cgdeboer-toptal]

No description provided.

[mlissner]

A few things:

1. Let's uncomment the bit of code that does the actual work here.

2. In your function, can you please provide a docstring? Also, I don't think it needs double underscores. It can be called from anywhere, right? The replacement string is pretty different than the one on Stackoverflow. Any idea why?

3. In your test, do we need a file or could we just do a unit test for the function you added? If we do need a file, can we make it much, much smaller so that it's clear which part of it is problematic? As it is, Github won't even show me the file in the UI.

[cgdeboer-toptal]

Response:

1. It's commented out because it doesn't work yet. Nor does the original example from CL. Sort of WIP MR just to show the failing test. As I commented here Invalid XML character break docket parsers #348 (comment) .

2. Sure thing. My original line of reasoning here is that the filtering of the invalid XML characters/bytes/whatevers is really only relevant for that one function and has no use outside of parsing the html. Happy to make that a public function with a docstring, once we figure out what to put there.

3. I added the actual docket content from PACER to help narrow down the issue. Right now, all we know is that the contents of that file (the HTML from PACER) can't be parsed.. once we have a test that passes for that file, we can reduce it's size to contain just the nasty bits.

P.S apologies for accidentally closing and re-opening.

[mlissner]

Great, thanks @cgdeboer-toptal. I shouldn't cross streams, but 2.0.3 is pushed, by the way.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ flooie
❌ Calvin DeBoer

---

Calvin DeBoer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}