fix(background): use chrome.scripting.ExecutionWorld.MAIN for firefox…

… compatibility
freelawproject · Oct 4, 2024 · d197f9c · d197f9c
1 parent b714080
commit d197f9c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,6 +12,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         node-version: [14.x, 16.x, 18.x]
     steps:

diff --git a/CHANGES.md b/CHANGES.md
@@ -14,6 +14,7 @@ Fixes:
  - Corrected typo in build script, ensuring correct favicon path for Firefox releases([379](https://github.com/freelawproject/recap/issues/379), [397](https://github.com/freelawproject/recap-chrome/pull/397))
  - Refines the generateFileName method to accurately compute zip file names ([366](https://github.com/freelawproject/recap/issues/366), [399](https://github.com/freelawproject/recap-chrome/pull/399)).
  - Improves the reliability of PACER case ID retrieval on attachment pages ([369](https://github.com/freelawproject/recap/issues/369), [400](https://github.com/freelawproject/recap-chrome/pull/400)).
+ - Use chrome.scripting.ExecutionWorld.MAIN for firefox compatibility ([404](https://github.com/freelawproject/recap-chrome/pull/404))
 
 
 For developers:

diff --git a/src/utils/background.js b/src/utils/background.js
@@ -123,7 +123,7 @@ export function getAndStoreVueData(req, sender, sendResponse) {
     .executeScript({
       target: { tabId: sender.tab.id },
       func: getVueDiv,
-      world: 'MAIN',
+      world: chrome.scripting.ExecutionWorld.MAIN,
     })
     .then((injectionResults) => sendResponse(injectionResults));
 }
@@ -154,7 +154,7 @@ export function overwriteSubmitMethod(req, sender, sendResponse){
     .executeScript({
       target: { tabId: sender.tab.id },
       func: _overwriteScript,
-      world: 'MAIN',
+      world: chrome.scripting.ExecutionWorld.MAIN,
     })
     .then((injectionResults) => sendResponse(injectionResults));
 }