fix(district): Refine generateFileName method for large documents #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generateFileName method has been refined to accurately compute zip file names, even for cases where the first document exceeds 30 pages. Previously, the logic lead to an error in such cases. This update addresses the issue by employing a more robust approach to compute the file name.
ERosendo
force-pushed
the
366-fix-download-zip-files-with-more-than-30-pages
branch
from
d498ddb
to
d84fd70
Compare
mlissner
approved these changes
Sep 19, 2024
mlissner
deleted the
366-fix-download-zip-files-with-more-than-30-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes freelawproject/recap#366 by refining the
generateFileNamemethod to accurately compute zip file names, even for cases where the first document exceeds 30 pages. Previously, the logic lead to an error in such cases. This update addresses the issue by employing a more robust approach to compute the file name.Here are some GIFs demonstrating the download functionality: