Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement gas metering for WASM contract execution #1377

Merged
merged 14 commits into from
Jan 26, 2025
Merged

feat: implement gas metering for WASM contract execution #1377

merged 14 commits into from
Jan 26, 2025

Conversation

sanity
Copy link
Collaborator

@sanity sanity commented Jan 12, 2025

…e abuse and ensure controlled computation

@netsirius netsirius force-pushed the gas-metering-for-contracts branch from 0e65c94 to 9bd6562 Compare January 20, 2025 17:00
@netsirius netsirius requested a review from iduartgomez January 20, 2025 18:08
iduartgomez
iduartgomez reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@iduartgomez iduartgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good overall, added some comments

crates/core/src/transport/connection_handler.rs Show resolved Hide resolved
crates/core/src/wasm_runtime/contract.rs Outdated Show resolved Hide resolved
crates/core/src/wasm_runtime/error.rs Outdated Show resolved Hide resolved
crates/core/src/wasm_runtime/runtime.rs Outdated Show resolved Hide resolved
crates/core/src/wasm_runtime/tests/contract_metering.rs Outdated Show resolved Hide resolved
@netsirius netsirius force-pushed the gas-metering-for-contracts branch from bcb1903 to 42bbbdc Compare January 25, 2025 01:29
@netsirius netsirius force-pushed the gas-metering-for-contracts branch from 429b2aa to 24e7e90 Compare January 26, 2025 10:20
@netsirius netsirius marked this pull request as ready for review January 26, 2025 14:03
@iduartgomez iduartgomez changed the title Implement gas metering for WASM contract execution to prevent resourc… feat: implement gas metering for WASM contract execution Jan 26, 2025
@iduartgomez iduartgomez added this pull request to the merge queue Jan 26, 2025
Merged via the queue into main with commit 4863ab6 Jan 26, 2025
4 checks passed
@iduartgomez iduartgomez deleted the gas-metering-for-contracts branch January 26, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iduartgomez iduartgomez iduartgomez left review comments

@netsirius netsirius netsirius left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanity @netsirius @iduartgomez