-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like nothing was uploaded to release page.
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe still need to create the release? there's a button to do that at least...
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vezzra Could you create it?
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a release, but it doesn't have any files attached. I would manually upload them, but I can't find if there's a URL where the artifacts can be downloaded from TravisCI...
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you restart Travis CI job for release?
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking restart doesn't work. Would need to re-push perhaps?
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed another commit, but it doesn't redo the "Draft Github release". Perhaps if @Vezzra redoes setting the v12 tag to the latest commit?
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today has been very busy, the next two days might be as well. Will try to take a look at it asap, but it might take me until the weekend...
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm confused... I have now taken a look at it, and there definitely is a release draft, created by freeorion-bot 4 days ago (Monday), which has the build artefacts (the SDK archive files) correctly attached. Then there is a "v12" release created by @geoffthemedio 3 days ago (Tuesday) with just the default source code tarballs attached.
Judging by your comments above it seems you do not see the release draft created by the freeorion-bot?
I suggest deleting the release created by @geoffthemedio, and then proceed with publishing the draft created by the freeorion-bot, following @adrianbroher's instructions.
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me...
Edit: I actually do see the bit release with downloadable artifacts now. I don't think it was there when I made the manual release...
Edit2: I may have just looked at the list of tags, which still doesn't have downloadables linked.
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoffthemedio,
They don't, none of them have. AFAICT, only releases (which are bound to a tag) have descriptions and attachements...
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VirusTotal scan of the Win32 SDK: https://www.virustotal.com/gui/file/e5716919a576d4310baf53463fb1e981aec6c554796acb849835956053ae6b7d/detection
fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoffthemedio, it's certainly good to see that VirusTotal reports our Win32 SDK to be perfectly clean, but what has that got to do with the tokens in
.travis.yaml
discussed here? Just curious...fc07408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed a place to put the comment and this commit resulted in the files being published as far as I recall...