Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Boost to 1.86.0 #125

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Update Boost to 1.86.0 #125

merged 1 commit into from
Dec 29, 2024

Conversation

o01eg
Copy link
Contributor

@o01eg o01eg commented Dec 28, 2024

No description provided.

@o01eg
Copy link
Contributor Author

o01eg commented Dec 28, 2024

Test build https://github.com/o01eg/freeorion/actions/runs/12524727395/job/34935554127

Windows CMake projects passed but MSVS projects failed to build:

   SerializeEmpire.cpp
  SerializeModeratorAction.cpp
  SerializeMultiplayerCommon.cpp
    CL!InvokeCompilerPassW()+0x8267f
  INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\bin\HostX86\x86\CL.exe'
      Please choose the Technical Support command on the Visual C++
      Help menu, or open the Technical Support help file for more information
cl : command line  error D8040: error creating or communicating with child process [D:\a\freeorion\freeorion\msvc2022\Common\Common.vcxproj]

@geoffthemedio

This comment was marked as resolved.

Sign in to view
@o01eg

This comment was marked as resolved.

Sign in to view
@o01eg o01eg force-pushed the bump-boost-1.86.0 branch from fdd4ed7 to e8f21c7 Compare December 28, 2024 10:22
@geoffthemedio
Copy link
Member

freeorion/freeorion@1c90867 prevents the internal compiler error

@o01eg o01eg force-pushed the bump-boost-1.86.0 branch from e8f21c7 to ce573a3 Compare December 29, 2024 11:35
Vezzra
Vezzra approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@Vezzra Vezzra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@o01eg o01eg merged commit 12fe3b8 into freeorion:master Dec 29, 2024
3 checks passed
@o01eg o01eg deleted the bump-boost-1.86.0 branch December 29, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vezzra Vezzra Vezzra approved these changes

@geoffthemedio geoffthemedio Awaiting requested review from geoffthemedio

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@o01eg @geoffthemedio @Vezzra