Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'auto rotate' settings in preference screen as per request 226 in tracker #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

riyaz
Copy link

@riyaz riyaz commented Mar 23, 2012

@riyaz
Copy link
Author

riyaz commented Mar 24, 2012

not sure how to ignore the line ending diff in my eclipse, ignore the white space diffs

@freezy
Copy link
Owner

freezy commented Apr 9, 2012

Hey, thanks for the patch (and sorry for the ridiculously long response). Unfortunately, when running it on Android 2.1, I'm getting the following exception in any list view:

java.lang.NoSuchMethodError: android.widget.AbsListView.setAdapter
    at org.xbmc.android.remote.presentation.controller.ListController$3.run(ListController.java:186)
    at android.os.Handler.handleCallback(Handler.java:609)
    at android.os.Handler.dispatchMessage(Handler.java:92)
    at android.os.Looper.loop(Looper.java:123)
    at android.app.ActivityThread.main(ActivityThread.java:4595)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:521)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
    at dalvik.system.NativeStart.main(Native Method)

@freezy
Copy link
Owner

freezy commented Apr 9, 2012

Hmm, when reverting the Android reference in Eclipse from 4.0.3 to 2.3.3, it seems to work. Can you confirm your tests with 2.3.3? Any reason why you set it to 4.0.3?

@riyaz
Copy link
Author

riyaz commented Apr 10, 2012

Opps, looks like some SDK issue, I have tested in my ICS device so I gave it as 4.0.3, I will verify with 2.3.3 and update the results.

@riyaz
Copy link
Author

riyaz commented Apr 10, 2012

App works fine with 2.3.3, have been using my modified for few few found no issues with the fix.

@freezy
Copy link
Owner

freezy commented Apr 10, 2012

Ok, cool. Do you want to update the pull request so it merges, otherwise I'll try later.

@riyaz
Copy link
Author

riyaz commented Apr 11, 2012

Updated the project.properties, below changes are required for the fix, it has some line ending diffs, which should be ignored

ac31be8
da94aba
04d3d02
5ce2a0a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants