Merge pull request #5 from vasco-santos/fix/ipv4-function-return-value

fix: ipv4 function return value
frenchbread · Nov 29, 2020 · 59fde62 · 59fde62
2 parents ef75bd5 + 12fe854
commit 59fde62
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "private-ip",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "Check if IP address is private.",
   "main": "index.js",
   "repository": {

diff --git a/src/index.js b/src/index.js
@@ -1,7 +1,7 @@
 const Netmask = require('netmask').Netmask
 const isIp = require('is-ip')
 
-function netmaskCheck (params) {
+function ipv4Check (params) {
   let privateRanges = [
     '0.0.0.0/8',
     '10.0.0.0/8',
@@ -31,6 +31,7 @@ function netmaskCheck (params) {
   for (let r of privateRanges) {
     if (r.contains(params)) return true
   }
+  return false
 }
 
 function ipv6Check (params) {
@@ -51,7 +52,7 @@ function ipv6Check (params) {
 
 export default (ip) => {
   if (isIp.v4(ip) || ip.startsWith('0')) {
-    return netmaskCheck(ip)
+    return ipv4Check(ip)
   }
   return ipv6Check(ip)
 }