Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tv_hma #494

Merged
merged 7 commits into from
Sep 19, 2024
Merged

fix tv_hma #494

merged 7 commits into from
Sep 19, 2024

Conversation

stash86
Copy link
Contributor

@stash86 stash86 commented Sep 18, 2024 •
edited
Loading

Current implementation of tv_hma is broken.

The changes are

  • tv_hma and tv_wma would return Series instead of DataFrame
  • Now you can either supply dataframe and column name, or just a series. So you can do tv_hma(dataframe, 9, "open") or tv_hma(dataframe["open"], 9) to match ta-lib's implementation of MA functions

xmatthias
xmatthias approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@xmatthias xmatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@xmatthias xmatthias merged commit 9b633a3 into freqtrade:main Sep 19, 2024
25 checks passed
@stash86 stash86 deleted the tv_hma branch September 20, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmatthias xmatthias xmatthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stash86 @xmatthias