Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete too early start before progress block registered #56

Closed
wants to merge 1 commit into from
Closed

Delete too early start before progress block registered #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Source/Promise+Progress.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import Foundation
public extension Promise {

@discardableResult public func progress(_ block: @escaping (Float) -> Void) -> Promise<T> {
tryStartInitialPromiseAndStartIfneeded()
let p = newLinkedPromise()
syncStateWithCallBacks(
success: p.fulfill,
Expand Down
4 changes: 4 additions & 0 deletions thenTests/Helpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,11 @@ func waitTime(_ time: Double, callback: @escaping () -> Void) {

func upload() -> Promise<Void> {
return Promise { (resolve: @escaping (() -> Void), _: @escaping ((Error) -> Void), progress) in
progress(0.8)
waitTime {
progress(0.8)
waitTime {
progress(0.8)
resolve()
}
}
Expand All @@ -127,9 +129,11 @@ func upload() -> Promise<Void> {

func failingUpload() -> Promise<Void> {
return Promise { (_: @escaping (() -> Void), reject: @escaping ((Error) -> Void), progress) in
progress(0.8)
waitTime {
progress(0.8)
waitTime {
progress(0.8)
reject(NSError(domain: "", code: 1223, userInfo: nil))
}
}
Expand Down