Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream fixes, simplified controller resolving #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

digitalkaoz
Copy link

fixed composer deps

now the controllers stay untouched, it means normal symfony request and response.
the converting is done in the application itself.

although the react request/response are available as request attributes.

@igorw
Copy link
Contributor

igorw commented Dec 12, 2014

Using symfony request/response here basically eliminates the advantage of using react in the first place, which is the ability to stream responses.

Also, please note that this project is a proof of concept and not really intended for production use.

@digitalkaoz
Copy link
Author

the react request and reponse objects are still available as request attributes. most of the time you wont stream line by line, but if your willing to you can.

and yes i know its a POC ;) but i really like how easy it is to switch your silex app to a react socket approach (and see 5times the speed ;) ) with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants