Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture and emit input end event #38

Merged
merged 2 commits into from
Aug 30, 2017

Conversation

jasonrsmith
Copy link

This is another PR for #24. It forwards the end event through the InputStream class and through the Client, similar to how errors are handled.

I need to handle server-side restarts, and I can't detect a disconnection without this fix.

Thank you!

Jason

@clue
Copy link
Contributor

clue commented Sep 8, 2015

There's ongoing discussion about whether it makes sense to completely drop the end event here: reactphp/stream#21

As such, I would suggest updating this PR to use the close event instead (which also appears to be more semantically correct here).

Otherwise LGTM 👍

Thanks for your contribution! :)

@jasonrsmith
Copy link
Author

@clue , Sounds good. I updated to use "close" instead".

Thanks!

Jason

@clue
Copy link
Contributor

clue commented Sep 8, 2015

Thanks for the quick update! LGTM 👍

@Easen
Copy link
Contributor

Easen commented May 13, 2016

+1

@brettmc
Copy link

brettmc commented Feb 22, 2017

is anybody still around that could merge this very useful pull request? It does exactly what I need to be able to tell when my server connection dies so that I can take action accordingly.

@davidkmenta
Copy link

Hi guys!

What about this PR? Will be merged? :)

@WyriHaximus WyriHaximus merged commit 6451fbb into friends-of-reactphp:master Aug 30, 2017
@WyriHaximus
Copy link
Member

Thanks, will look into tagging a new release later today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants