Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement full check registration + win gift card flow #25

Merged
merged 19 commits into from
Apr 19, 2024
Merged

Conversation

davepeck
Copy link
Contributor

When merged, closes #12 closes #13 closes #16

@davepeck davepeck self-assigned this Apr 17, 2024
@davepeck
Copy link
Contributor Author

It sorta made logical sense to make fireworks/banner updates a key part of this PR too. So here we are. When merged, also closes #18 too.

@davepeck
Copy link
Contributor Author

davepeck commented Apr 17, 2024

Screenshot 2024-04-17 at 4 20 28 PM

@davepeck
Copy link
Contributor Author

The "good path", where students provide a valid email for an active contest, is done working and tested. Now on to the edge cases.

@davepeck
Copy link
Contributor Author

davepeck commented Apr 19, 2024

Still to do:

  • On the good path, when a new gift card is generated, be sure to send an email that also contains the claim code.
  • If user verifies their registration with a .edu address that does not match their expected school, show UI that asks them for an alternative. If the alternative is valid, finish the flow. Otherwise, keep asking until the user cancels.
  • If user visits school landing page and there is no active contest, encourage registration (and mention when the previous contest ended, if any)
  • If user verifies their registration but no contest is active, alter the validation link and email flow to simply say "validate my email" and bring them back to the site thanking them for their work.
  • Make sure all text is still correct even in the no-active-contest path.
  • Make sure that if a user verifies their registration before a contest closes, but validates their email after, we still issue a gift card tied to the correct contest.
  • Make sure that errors in generating gift cards are reflected on the site, with a prominent link to reach out to customer support ([email protected]).
  • Make sure everything looks good on the iphone too

@davepeck
Copy link
Contributor Author

Absorbing #10 and #19 into this PR, too.

@davepeck davepeck merged commit b38b006 into main Apr 19, 2024
2 checks passed
@davepeck davepeck deleted the dave/regflow branch April 19, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment