feat: adding types for frontChat #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BayanBennett
reviewed
Feb 7, 2025
| useDefaultLauncher?: boolean; | ||
| onInitCompleted?: () => void; | ||
| // Allow any other key with a value of string, boolean, object, or undefined | ||
| [key: string]: string | boolean | object | undefined; |
There was a problem hiding this comment.
Can it be number as well? If so, maybe unknown is a better fit.
Suggested change
| [key: string]: string | boolean | object | undefined; | |
| [key: string]: unknown; |
BayanBennett
reviewed
Feb 7, 2025
Co-authored-by: Bayan Bennett <[email protected]>
|
Thank you for opening this PR, and apologies for the delayed response. Improved types for this package are on our radar, and we will be looking to add these changes soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have added types for cmd type and adding front chat params from the documentation for easier type navigation based on documentation while keeping the option to pass additional params as needed