Implement generation of shields for headers #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to change the header shield on the pages that use it. The only thing you need to take care of is setting the
shieldvalue the same for the English and Dutch pages, which is done automatically as most of these are set in the layout instead.The
organisationone is kept the same.The shortcode has been changed so you can add a string to generate a shield:
Additionally, there is now an empty shield as well. We can use this if we want to change the members page layout to always show a shield but show the empty one until someone has picked "what shield" they want based on a generated value.
I have updated the shield generator to reflect these changes. Friendly reminder that you can use the shield generator to figure out what value to use to ... generate a nice shield. E.g "Derk-Jan" and "SleeplessByte" will yield completely different shields, as expected.