Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZZO MVPish #2595

Merged
merged 9 commits into from
Jan 15, 2025
Merged

ZZO MVPish #2595

merged 9 commits into from
Jan 15, 2025

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Jan 13, 2025

Describe your changes

A minimal ZZZO implementation with barebones disc editor, combination solver with no datamine, assets, formulas.

Tasks

  • Create apps/zzz-frontend ⏫ (copy from sr-frontend) ✅ 2025-01-13
  • Create libs/zzz/const 🔼 ✅ 2025-01-13
    • Add main/subs keys ✅ 2025-01-13
    • Add sets keys ✅ 2025-01-13
  • Create libs/zzz/db 🔼 (copy from sr-db) ✅ 2025-01-13
    • database 🔺 ✅ 2025-01-13
    • iDisc ⏫ ✅ 2025-01-13
  • Create libs/zzz/ui 🔼 ✅ 2025-01-13
    • Create DiscCard ⏫ ✅ 2025-01-13
    • Create DescEditor ⏫ ✅ 2025-01-13
      • Scan disc using screenshots ⏬
  • Create libs/zzz/db-ui ✅ 2025-01-13
  • Create libs/zzz/page-discs 🔼 ✅ 2025-01-13
    • Show discs in a grid ✅ 2025-01-13
    • Disc filters ⏬
  • Create libs/zzz/page-optimize 🔼 ✅ 2025-01-13
    • Basic inputs for base stats (char + wengine) ✅ 2025-01-13
    • Basic inputs for criterias ✅ 2025-01-13
      • 4-p sets ✅ 2025-01-13
      • stat ranges ✅ 2025-01-13
    • Output build ✅ 2025-01-13
  • Create libs/zzz/settings ✅ 2025-01-13
    • db management UI (copy and paste) ✅ 2025-01-13
  • Create libs/zzz/solver 🔼 ✅ 2025-01-13
    • base(char +wengine) + discs + criteria => builds that match criteria ✅ 2025-01-13
    • placeholder sheets (disc 2-4p stats) ✅ 2025-01-13
    • webworker 🔼 ✅ 2025-01-13

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

coderabbitai bot commented Jan 13, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

70 files out of 154 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

[sr-frontend] [Mon Jan 13 22:06:11 UTC 2025] - Deployed 0c12ba2 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon Jan 13 22:06:27 UTC 2025] - Deployed 0c12ba2 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 14 02:06:17 UTC 2025] - Deployed 1e2516f to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 14 02:07:08 UTC 2025] - Deployed 1e2516f to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 14 02:39:12 UTC 2025] - Deployed fd1fc7e to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 14 02:39:27 UTC 2025] - Deployed fd1fc7e to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 14 02:44:28 UTC 2025] - Deployed c894468 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 14 02:44:52 UTC 2025] - Deployed c894468 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 14 02:48:22 UTC 2025] - Deployed 3ec10d9 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 14 02:48:43 UTC 2025] - Deployed 3ec10d9 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 14 03:49:58 UTC 2025] - Deployed 13b48ad to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 14 03:50:29 UTC 2025] - Deployed 13b48ad to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Jan 15 04:10:58 UTC 2025] - Deployed b32c41e to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Jan 15 04:11:06 UTC 2025] - Deployed b32c41e to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Jan 15 04:22:47 UTC 2025] - Deployed 4729ad9 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Jan 15 04:23:00 UTC 2025] - Deployed 4729ad9 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Jan 15 04:33:38 UTC 2025] - Deployed 579cb3c to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed Jan 15 04:33:43 UTC 2025] - Deployed 579cb3c to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[Wed Jan 15 05:03:15 UTC 2025] - Deleted deployment

[zzz-frontend] [Fri Jan 17 05:59:19 UTC 2025] - Deployed 3fd901d to https://genshin-optimizer-prs.github.io/pr/2595/zzz-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Jan 17 06:00:00 UTC 2025] - Deployed 3fd901d to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Jan 17 06:00:49 UTC 2025] - Deployed 3fd901d to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available)

@frzyc frzyc marked this pull request as ready for review January 15, 2025 02:57
@frzyc frzyc requested a review from nguyentvan7 January 15, 2025 04:51
Copy link
Collaborator

@nguyentvan7 nguyentvan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thang boss

@frzyc frzyc merged commit 3fd901d into master Jan 15, 2025
11 checks passed
@frzyc frzyc deleted the zzzo_mvpish branch January 15, 2025 05:02
@frzyc frzyc added the ZO Zenless Optimizer label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZO Zenless Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants