-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZZO MVPish #2595
ZZO MVPish #2595
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 70 files out of 154 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[sr-frontend] [Mon Jan 13 22:06:11 UTC 2025] - Deployed 0c12ba2 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Mon Jan 13 22:06:27 UTC 2025] - Deployed 0c12ba2 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Tue Jan 14 02:06:17 UTC 2025] - Deployed 1e2516f to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue Jan 14 02:07:08 UTC 2025] - Deployed 1e2516f to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Tue Jan 14 02:39:12 UTC 2025] - Deployed fd1fc7e to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue Jan 14 02:39:27 UTC 2025] - Deployed fd1fc7e to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Tue Jan 14 02:44:28 UTC 2025] - Deployed c894468 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue Jan 14 02:44:52 UTC 2025] - Deployed c894468 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Tue Jan 14 02:48:22 UTC 2025] - Deployed 3ec10d9 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue Jan 14 02:48:43 UTC 2025] - Deployed 3ec10d9 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Tue Jan 14 03:49:58 UTC 2025] - Deployed 13b48ad to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue Jan 14 03:50:29 UTC 2025] - Deployed 13b48ad to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Jan 15 04:10:58 UTC 2025] - Deployed b32c41e to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Jan 15 04:11:06 UTC 2025] - Deployed b32c41e to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Jan 15 04:22:47 UTC 2025] - Deployed 4729ad9 to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Jan 15 04:23:00 UTC 2025] - Deployed 4729ad9 to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Jan 15 04:33:38 UTC 2025] - Deployed 579cb3c to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Jan 15 04:33:43 UTC 2025] - Deployed 579cb3c to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [Wed Jan 15 05:03:15 UTC 2025] - Deleted deployment [zzz-frontend] [Fri Jan 17 05:59:19 UTC 2025] - Deployed 3fd901d to https://genshin-optimizer-prs.github.io/pr/2595/zzz-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Jan 17 06:00:00 UTC 2025] - Deployed 3fd901d to https://genshin-optimizer-prs.github.io/pr/2595/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Fri Jan 17 06:00:49 UTC 2025] - Deployed 3fd901d to https://genshin-optimizer-prs.github.io/pr/2595/sr-frontend (Takes 3-5 minutes after this completes to be available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thang boss
Describe your changes
A minimal ZZZO implementation with barebones disc editor, combination solver with no datamine, assets, formulas.
Tasks
apps/zzz-frontend
⏫ (copy fromsr-frontend
) ✅ 2025-01-13libs/zzz/const
🔼 ✅ 2025-01-13libs/zzz/db
🔼 (copy fromsr-db
) ✅ 2025-01-13iDisc
⏫ ✅ 2025-01-13libs/zzz/ui
🔼 ✅ 2025-01-13DiscCard
⏫ ✅ 2025-01-13DescEditor
⏫ ✅ 2025-01-13libs/zzz/db-ui
✅ 2025-01-13libs/zzz/page-discs
🔼 ✅ 2025-01-13libs/zzz/page-optimize
🔼 ✅ 2025-01-13libs/zzz/settings
✅ 2025-01-13libs/zzz/solver
🔼 ✅ 2025-01-13Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.