Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beta deployments #2637

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix beta deployments #2637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/beta-go-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
with:
frontend_name: 'frontend'
deployment_name: 'beta'
repo_name: ${{ vars.PR_REPO }}
repo_var_name: 'PR_REPO'
repo_deploy_secret_name: 'PR_REPO_SSH_KEY'
show_dev_components: true
2 changes: 1 addition & 1 deletion .github/workflows/beta-sro-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
with:
frontend_name: 'sr-frontend'
deployment_name: 'beta'
repo_name: ${{ vars.PR_REPO }}
repo_var_name: 'PR_REPO'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Beta deployment failures unrelated to parameter rename - found syntax error in workflow

The parameter rename is correctly implemented, but all beta deployments are failing due to a syntax error in the shared build-frontend.yml workflow. The 'Build frontend' step has an incomplete command where environment variables are set but no actual command is specified:

      - name: Build frontend
        run: |
          NX_URL_GITHUB_GO_CURRENT_VERSION="https://github.com/${{ github.repository }}/commit/$(git rev-parse HEAD)" \
          NX_DAEMON="false" \
          NX_SHOW_DEV_COMPONENTS="${{inputs.show_dev_components}}" \
🔗 Analysis chain

LGTM! Completes the systematic update across all beta workflows.

The parameter rename from repo_name to repo_var_name has been consistently applied across all beta release workflows. This systematic update suggests a fix for how repository variables are handled during beta deployments.

To ensure this change actually fixes beta deployments, let's check the deployment history:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check recent deployment history and any related issues

# Check recent workflow runs for these files
gh run list --workflow beta-go-release.yml --limit 5
gh run list --workflow beta-zo-release.yml --limit 5
gh run list --workflow beta-sro-release.yml --limit 5

# Look for related issues about beta deployments
gh issue list --search "beta deploy" --state all --limit 5

Length of output: 2256

Script:

#!/bin/bash
# Get detailed logs for the most recent failed runs
gh run view 13000596375 --log  # GO
gh run view 13000596379 --log  # ZO
gh run view 13000596350 --log  # SRO

Length of output: 206

Script:

#!/bin/bash
# Check the workflow file content and any reusable workflows it references
cat .github/workflows/beta-sro-release.yml
fd -e yml -e yaml "reusable.*beta.*workflow" .github/workflows/

Length of output: 604

Script:

#!/bin/bash
# Check the reusable workflow content
cat .github/workflows/build-frontend.yml

Length of output: 3735

repo_deploy_secret_name: 'PR_REPO_SSH_KEY'
show_dev_components: true
2 changes: 1 addition & 1 deletion .github/workflows/beta-zo-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
with:
frontend_name: 'zzz-frontend'
deployment_name: 'beta'
repo_name: ${{ vars.PR_REPO }}
repo_var_name: 'PR_REPO'
repo_deploy_secret_name: 'PR_REPO_SSH_KEY'
show_dev_components: true
Loading