Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZO Convert disc data from ZZZ-Drive-Disk-Scanner #2641

Merged
merged 1 commit into from
Jan 28, 2025
Merged

ZO Convert disc data from ZZZ-Drive-Disk-Scanner #2641

merged 1 commit into from
Jan 28, 2025

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented Jan 28, 2025

Describe your changes

Adding a quick and dirty shim layer to scanned data from https://github.com/samsaq/ZZZ-Drive-Disk-Scanner
image

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc added the ZO Zenless Optimizer label Jan 28, 2025
Copy link
Contributor

coderabbitai bot commented Jan 28, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 31e6114 and f565ae1.

📒 Files selected for processing (11)
  • libs/common/util/src/lib/object.ts (1 hunks)
  • libs/zzz/consts/src/disc.ts (2 hunks)
  • libs/zzz/db/src/driveDiskScanner.ts (1 hunks)
  • libs/zzz/db/src/index.ts (1 hunks)
  • libs/zzz/dm/src/dm/disc/discIdMap.json (1 hunks)
  • libs/zzz/dm/src/dm/disc/discKeys.json (1 hunks)
  • libs/zzz/dm/src/dm/disc/discNames.json (1 hunks)
  • libs/zzz/dm/src/dm/disc/discs.ts (1 hunks)
  • libs/zzz/dm/src/dm/disc/index.ts (1 hunks)
  • libs/zzz/dm/src/dm/index.ts (1 hunks)
  • libs/zzz/ui/src/Settings/UploadCard.tsx (2 hunks)
 _________________________________
< All your bugs are belong to us. >
 ---------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Tip

You can make CodeRabbit's review more strict using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting in your project's settings in CodeRabbit to assertive to make CodeRabbit's nitpick more issues in your PRs.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Jan 28, 2025

[zzz-frontend] [Tue Jan 28 07:20:10 UTC 2025] - Deployed c4db44d to https://genshin-optimizer-prs.github.io/pr/2641/zzz-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Jan 28 07:20:30 UTC 2025] - Deployed c4db44d to https://genshin-optimizer-prs.github.io/pr/2641/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Jan 28 07:20:50 UTC 2025] - Deployed c4db44d to https://genshin-optimizer-prs.github.io/pr/2641/frontend (Takes 3-5 minutes after this completes to be available)

[zzz-frontend] [Tue Jan 28 07:21:18 UTC 2025] - Deployed c4db44d to https://genshin-optimizer-prs.github.io/pr/2641/zzz-frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jan 28 07:44:05 UTC 2025] - Deleted deployment

@frzyc frzyc merged commit a43ef49 into master Jan 28, 2025
15 of 16 checks passed
@frzyc frzyc deleted the zdds_shim branch January 28, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZO Zenless Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant