-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a shared gameOpt library #2684
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 178 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[zzz-frontend] [Sun Feb 9 04:48:59 UTC 2025] - Deployed a4ceb02 to https://genshin-optimizer-prs.github.io/pr/2684/zzz-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Feb 9 04:50:03 UTC 2025] - Deployed a4ceb02 to https://genshin-optimizer-prs.github.io/pr/2684/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Feb 9 04:50:24 UTC 2025] - Deployed a4ceb02 to https://genshin-optimizer-prs.github.io/pr/2684/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Feb 9 05:14:48 UTC 2025] - Deployed 789836d to https://genshin-optimizer-prs.github.io/pr/2684/sr-frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Sun Feb 9 05:14:52 UTC 2025] - Deployed 789836d to https://genshin-optimizer-prs.github.io/pr/2684/zzz-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Feb 9 05:15:09 UTC 2025] - Deployed 789836d to https://genshin-optimizer-prs.github.io/pr/2684/frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Sun Feb 9 05:41:31 UTC 2025] - Deployed 5040b80 to https://genshin-optimizer-prs.github.io/pr/2684/zzz-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Feb 9 05:41:39 UTC 2025] - Deployed 5040b80 to https://genshin-optimizer-prs.github.io/pr/2684/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Feb 9 05:41:43 UTC 2025] - Deployed 5040b80 to https://genshin-optimizer-prs.github.io/pr/2684/frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Feb 9 17:31:54 UTC 2025] - Deployed de9a745 to https://genshin-optimizer-prs.github.io/pr/2684/sr-frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Sun Feb 9 17:32:01 UTC 2025] - Deployed de9a745 to https://genshin-optimizer-prs.github.io/pr/2684/zzz-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Feb 9 17:33:17 UTC 2025] - Deployed de9a745 to https://genshin-optimizer-prs.github.io/pr/2684/frontend (Takes 3-5 minutes after this completes to be available) [Mon Feb 10 00:11:13 UTC 2025] - Deleted deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense(and ease of OCD) to rename gameOpt
to game-opt
so that we don't have camelcase in our dash-case imports paths.
Describe your changes
gameOpt
, intended for use by our game optimizers. These changes are shared between all pando-implementations for the games, but they are not directly shareable by all possible use-cases of Pando, and would muddy the intention/design of Pandoq
,qt
type-safely, and being able tolistFormulas
andlistConds
pando
/common
togameOpt
Current structure:
![image](https://private-user-images.githubusercontent.com/36019388/411344535-5570481f-3877-405a-b4fe-f5369e1c2a66.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDYyMTAsIm5iZiI6MTczOTQ0NTkxMCwicGF0aCI6Ii8zNjAxOTM4OC80MTEzNDQ1MzUtNTU3MDQ4MWYtMzg3Ny00MDVhLWI0ZmUtZjUzNjllMWMyYTY2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDExMjUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1MmE1MWM0ODdkYjQ4ZTY1MWZmYjk1MzE4MWRlODI3YzU4MzcwZTg1N2ZkOWM0MTBhYTE3M2I2ZTUzMjg2M2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.3DCYMjwX7g9W8MSpMRqMksaoBQLA6YvVbs7P_PvtITo)
New structure:
![image](https://private-user-images.githubusercontent.com/36019388/411344547-b03a3be5-23cb-41e2-9211-a753552fd59a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDYyMTAsIm5iZiI6MTczOTQ0NTkxMCwicGF0aCI6Ii8zNjAxOTM4OC80MTEzNDQ1NDctYjAzYTNiZTUtMjNjYi00MWUyLTkyMTEtYTc1MzU1MmZkNTlhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDExMjUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI4YTc2Y2RiNzA0OTJkOTc0MzNhNWQ0YzM4ZDA4ZTU4ZDJhNjQzYzlhOWIwOWJjNmNhMmE5YjBlMTZhNzYyMWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.w8IPUjNuKy2XYT3J3NBOvk1peFvqRB1OhFCzzbW1DuA)
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.