Union, tests and fixes #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramilabzalov1
suggested changes
Mar 23, 2022
graphene_django_pretty/types/base.py
Outdated
| """Base union type.""" | ||
|
|
||
| class Meta: | ||
| types = (None,) |
There was a problem hiding this comment.
Наверное, стоит добавить проверку, что здесь лежат только DjangoObjectType в методе init_subclass_with_meta
| @@ -191,7 +207,8 @@ def merge_model_and_interface_fields(cls, django_fields, interface_fields) -> Di | |||
| for field_name, field_description in interface_fields.items(): | |||
| # replace description from interface if it is not none. | |||
| if field_description.description: | |||
| merged_fields.get(field_name).description = field_description.description | |||
| merged_fields.get( | |||
There was a problem hiding this comment.
можешь плз поправить везде переносы
tests/test_types/test_union.py
Outdated
| from tests.django_setup.models import Article, Author, Post | ||
|
|
||
|
|
||
| class PostType(DjangoObjectType): |
There was a problem hiding this comment.
Тут для тестов, наверное, лучше стоит использовать наш BaseDjangoObjectType
graphene_django_pretty/types/base.py
Outdated
| @classmethod | ||
| def resolve_type(cls, instance, info): | ||
| """Resolving grapql type by models instance.""" | ||
| for type in cls._meta.types: |
There was a problem hiding this comment.
Здесь бы переименовать на type_, чтобы не перезаписывать внутреннюю функцию python-а
graphene_django_pretty/types/base.py
Outdated
| @@ -36,6 +35,21 @@ class PatchedDjangoObjectTypeOptions(ObjectTypeOptions): | |||
| default_resolver = None | |||
|
|
|||
|
|
|||
| class BaseUnion(graphene.Union): | |||
There was a problem hiding this comment.
Тут бы тоже переименовать, что это DjangoModelUnion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.